src: Fix "no-unnecessary-condition" issues (HMS-5355) #2760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can squash the commits later, needed to keep them separate to not get lost in the changes. |
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #2760 +/- ##
==========================================
- Coverage 84.77% 84.76% -0.01%
==========================================
Files 187 187
Lines 21298 21295 -3
Branches 2099 2099
==========================================
- Hits 18055 18051 -4
- Misses 3221 3222 +1
Partials 22 22
Continue to review full report in Codecov by Sentry.
|
regexowl
force-pushed
the
fix-no-unnecessary-condition-issues
branch
from
4b3239b to
f679fab
Compare
|
/jira-epic HMS-5173 |
schutzbot
changed the title
regexowl
force-pushed
the
fix-no-unnecessary-condition-issues
branch
2 times, most recently
from
340f8b9 to
864ad43
Compare
croissanne
force-pushed
the
fix-no-unnecessary-condition-issues
branch
from
864ad43 to
2dc7918
Compare
regexowl
force-pushed
the
fix-no-unnecessary-condition-issues
branch
from
2dc7918 to
fc85d85
Compare
|
/retest |
lucasgarfield
force-pushed
the
fix-no-unnecessary-condition-issues
branch
from
fc85d85 to
65984a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased on #2755
This is a first batch of "no-unnecessary-condition" issue fixes.
JIRA: HMS-5355